Review Board

beta

Make the mailing list for a group optional

Updated 1 year, 6 months ago

David Trowbridge Reviewers
trunk reviewboard
97
None Review Board SVN 
A few people have requested that groups could exist without a
mailing list to send to, and have it so relevant review requests
and reviews get e-mailed to any individual subscribers instead
of to the list.

This change (hopefully) does that.  It should be a fairly
self-explanatory patch.
Fixed up unit tests for new API and ran them.  The actual code
path for groups without mailing lists hasn't been tested, since
I'm not sure how to modify the fixture to add relevant test data.
Ship it!
Josh Stone
Posted 1 year, 6 months ago (June 16th, 2007, 6:14 p.m.)
Thanks for this change -- I had thought it a little weird that one could be a member of a group but not receive emails for that group (if not on the mailing list).  Sending to all group members fits my mindset a lot better.
Loading diff fragment... 
As an aside, the recipient_table -> recipient_list could be better expressed with a set().
Ship it!
Christian Hammond
Posted 1 year, 6 months ago (June 17th, 2007, 3:56 p.m.)
Looks good to me.
Ship it!
Alan Falloon
Posted 1 year, 6 months ago (June 18th, 2007, 6:35 a.m.)
Thanks a lot. This looks exactly like what I was looking for.