Review Board

beta

Return an error if trying to set a summary with newlines.

Updated 3 months, 1 week ago

David Trowbridge Reviewers
trunk reviewboard
548
None Review Board SVN
Return an error if trying to set a summary with newlines.
    
At the moment, it's possible to create a review request that has a summary with
a newline in it. This works okay until RB tries to send email with that summary
as a subject, at which point it will blow up with an ugly backtrace.
    
I considered normalizing, but that's uglier. Since this is something that can
only be done via the JSON API, we might as well have the API return an error
instead.

 
Ship it!
Posted 3 months, 1 week ago (September 29th, 2008, 4:50 p.m.)
Looks good, just one comment..
Loading diff fragment...
Should this be localized?
  1. David Trowbridge 3 months, 1 week ago (September 29th, 2008, 5 p.m.)
    We don't localize anything else in our API errors.
  2. Christian Hammond 3 months, 1 week ago (September 29th, 2008, 5:03 p.m.)
    Fair point. Ship it!