Review Board

beta

Fix counting of diffs with drafts.

Updated 4 months ago

David Trowbridge Reviewers
trunk reviewboard
469
None Review Board SVN
When a user has a draft diff, we counted wrong when choosing whether to show the
revision selector. We were not counting draft diffs in this total. The result of
this was:
- If you had only a draft diff, we showed a useless revision selector.
- If you have one published diff and one draft diff, we did not show the
  (potentially very useful) revision selector.
- If you had more than one published diff, it would show a revision selector.
Looked at the diff viewer with various combinations of published and unpublished diffs.
Ship it!
Posted 4 months ago (September 6th, 2008, 11:19 p.m.)
Looks good.
  1. David Trowbridge 4 months ago (September 7th, 2008, 10:59 a.m.)
    Thanks!