Submitter:	Florian Föbel	Reviewers
Branch:		Groups:	reviewboard
Bugs:		People:
Change Number:	None	Repository:	Review Board SVN

Description:

This one's a request from one of my users who wanted to see who's attending a group:
- Adds a member count column to the group datagrid.
- The new column links to a modified version of the submitter datagrid which only shows the members of the specified group.

Testing Done:

Tested using my local test instance.

Diff revision 2 (Latest)

Jump to revision:	1 2
Changes between r2 and:	1 2

Files Changed:

/trunk/reviewboard/urls.py: 1 change [ 1 ]
/trunk/reviewboard/reviews/datagrids.py: 4 changes [ 1 2 3 4 ]
/trunk/reviewboard/reviews/views.py: 1 change [ 1 ]

Expand changes

             name="user"),
         # Groups
         url(r'^groups/$', 'group_list', name="all-groups"),
         url(r'^groups/(?P<name>[A-Za-z0-9_-]+)/$', 'group', name="group"),
         url(r'^groups/(?P<name>[A-Za-z0-9_-]+)/members/$', 'group_members', name="group_members"),
+    )
     # django.contrib
     urlpatterns += patterns('django.contrib',

     def render_data(self, obj):
         return str(getattr(obj, self.field_name).filter(public=True,
                                                         status='P').count())
 class GroupMemberCountColumn(Column):
     """
     A column used to show the number of users that registered for a group.
     """
     def __init__(self, *args, **kwargs):
         Column.__init__(self, *args, **kwargs)
         self.link = True
         self.link_func = self.link_to_object
     def render_data(self, group):
         return str(group.users.count())
     def link_to_object(self, group, value):
         return reverse('group_members', args=[group.name])
 class ReviewCountColumn(Column):
     """
     A column showing the number of reviews for a review request.
     """
     def __init__(self, label=_("Reviews"),
                            link=True, expand=True)
     pending_count = PendingCountColumn(_("Pending Reviews"),
                                        field_name="directed_review_requests",
                                        shrink=True)
-    def __init__(self, request):
+    def __init__(self, request,
-        DataGrid.__init__(self, request, User.objects.filter(is_active=True),
+                 queryset=User.objects.filter(is_active=True),
-                          _("All submitters"))
+                 title=_("All submitters")):
         DataGrid.__init__(self, request, queryset, title)
         self.default_sort = ["username"]
         self.profile_sort_field = 'sort_submitter_columns'
         self.profile_columns_field = 'submitter_columns'
         self.default_columns = [
             "username", "fullname", "pending_count"
     name          = Column(_("Group ID"), link=True, sortable=True)
     displayname   = Column(_("Group Name"), field_name="display_name",
                            link=True, expand=True)
     pending_count = PendingCountColumn(_("Pending Reviews"),
                                        field_name="review_requests",
                                        link=True,
                                        shrink=True)
     member_count  = GroupMemberCountColumn(_("Members"),
                                            field_name="members",
-                                       shrink=True)
+                                           shrink=True)
     def __init__(self, request, title=_("All groups")):
         DataGrid.__init__(self, request, Group.objects.all(), title)
         self.profile_sort_field = 'sort_group_columns'

     return datagrid.render_to_response(template_name)
 @check_login_required
 def group_members(request, name, template_name='reviews/datagrid.html'):
     """
     A list of users registered for a particular group.
     """
     # Make sure the group exists
     get_object_or_404(Group, name=name)
     datagrid = SubmitterDataGrid(request,
         Group.objects.get(name=name).users.filter(is_active=True),
         _("Members of group %s") % name)
     return datagrid.render_to_response(template_name)
 @check_login_required
 def submitter(request, username, template_name='reviews/datagrid.html'):
     """
     A list of review requests owned by a particular user.
     """
     # Make sure the user exists

/trunk/reviewboard/urls.py: 1 change [ 1 ]
/trunk/reviewboard/reviews/datagrids.py: 4 changes [ 1 2 3 4 ]
/trunk/reviewboard/reviews/views.py: 1 change [ 1 ]

Review Board

beta

This change has been marked as submitted.

View review group members

Diff revision 2 (Latest)

Other reviews

Your comment