Review Board

beta

View review group members

Submitted
Updated 2 months, 3 weeks ago

Florian Föbel Reviewers
reviewboard
None Review Board SVN 
This one's a request from one of my users who wanted to see who's attending a group:
- Adds a member count column to the group datagrid.
- The new column links to a modified version of the submitter datagrid which only shows the members of the specified group.
Tested using my local test instance.
Christian Hammond
Posted 2 months, 3 weeks ago (August 25th, 2008, 1:24 a.m.)

   

  
    
   
  




   



    

     
     

      
       
       
       
       
      
      
       

        
         /trunk/reviewboard/reviews/datagrids.py
		 

		  (Diff revision 1)

		 
        
       

      

      

       

         
         

         166
         
class GroupMemberCountColumn(Column):

       


      

     

    

    

     
2 blank lines before this.

	 

  
    
   

   
  1. 
    
    
     
    
      
      Florian Föbel
      2 months, 3 weeks ago (August 25th, 2008, 1:54 a.m.)
      
     
    
     
    fixed
    
    
    
   
    2. 


  



    


    

     
     

      
       
       
       
       
      
      
       

        
         /trunk/reviewboard/reviews/datagrids.py
		 

		  (Diff revision 1)

		 
        
       

      

      

       

         360
         
    def __init__(self, request):

         375
         
    def __init__(self, request, queryset=User.objects.filter(is_active=True), title=_("All submitters")):

       


      

     

    

    

     
Does this fit in 80 columns?

Wondering if it's bad at all to define this default value for User there. Probably okay I guess.

	 

  
    
   

   
  1. 
    
    
     
    
      
      Florian Föbel
      2 months, 3 weeks ago (August 25th, 2008, 2:01 a.m.)
      
     
    
     
    I added some line-wraps so it won't be over 80 columns.
The default values were added because I did not want to alter the behaviour of SubmitterDataGrid. Anything else would require an adjustment to the lines where SubmitterDataGrid is already used.
    
    
    
   
    2. 


  



    


    

     
     

      
       
       
       
       
      
      
       

        
         /trunk/reviewboard/reviews/datagrids.py
		 

		  (Diff revision 1)

		 
        
       

      

      

       

         
         

         401
         
    member_count    = GroupMemberCountColumn (_("Members"),

       


      

     

    

    

     
The "=" should line up, and no space before the "(". Also, all params should line up with the first param.

	 

  
    
   

   
  1. 
    
    
     
    
      
      Florian Föbel
      2 months, 3 weeks ago (August 25th, 2008, 1:54 a.m.)
      
     
    
     
    fixed
    
    
    
   
    2.