Review Board

beta

Enable Firefox's quick find

Updated 4 months, 4 weeks ago

Gareth Owen Reviewers
trunk reviewboard
491
None Review Board SVN 
Firefox uses "/" to launch the incremental Quick Find box at the bottom of the browser, but the "/" key was being mapped to the NextFile keyboard shortcut in the diff view page.

The simple solution is to remove the "/" shortcust key from the diff view page. 
Works on my server with Firefox 3.0.1

Diff revision 1 (Latest)

  1. trunk/reviewboard/htdocs/media/rb/scripts/diffviewer.js: 1 change [ 1 ]
trunk/reviewboard/htdocs/media/rb/scripts/diffviewer.js
Revision 1433 New Change
40 
        keys: "aAKP<m",
 40 
        keys: "aAKP<m",
41 
        onPress: function() { scrollToAnchor(GetNextFileAnchor(BACKWARD)); }
 41 
        onPress: function() { scrollToAnchor(GetNextFileAnchor(BACKWARD)); }
42 
    },
 42 
    },
43 

   43
   


  


  


   44


   
    { // Next file

   44
   
    { // Next file


  


 



 

  


   45


   
        keys: "fFJN>/",

   45
   
        keys: "fFJN>",


  


 



 

  


   46


   
        onPress: function() { scrollToAnchor(GetNextFileAnchor(FORWARD)); }

   46
   
        onPress: function() { scrollToAnchor(GetNextFileAnchor(FORWARD)); }


  


  


   47


   
    },

   47
   
    },


  


  


   48


   

   48
   


  


  


   49


   
    { // Previous diff

   49
   
    { // Previous diff


  


  


   50


   
        keys: "sSkp,,",

   50
   
        keys: "sSkp,,",


  


 



 













    

 
  1. trunk/reviewboard/htdocs/media/rb/scripts/diffviewer.js:
 
  
  1 change
   [
   
    
     1
    
   
]
    2.