View Diffpost-review: allow user to supply password on cmdline
Submitted
Updated 3 months ago
| Zach Carter | Reviewers | ||
| reviewboard | |||
| None | Review Board SVN | ||
post-review: allow user to supply password on cmdline
submitted this review with the modified script
Posted 3 months, 1 week ago (August 14th, 2008, 10:55 p.m.)
-
/trunk/reviewboard/contrib/tools/post-review (Diff revision 2) 165 if not options.submit_as:
165 username = raw_input('Username: ')166 username = raw_input('Username: ')167 else: username = options.submit_as
-
This would look a lot better like this: if options.submit_as: username = options.submit_as else: username = raw_input('Username: ') Same with the password field. -
/trunk/reviewboard/contrib/tools/post-review (Diff revision 2) 168 -
Trailing whitespace.
Looks good. Committed as r1450.