Fix publishing review requests from the web UI
Updated 5 months, 2 weeks ago
| Michael Plump | Reviewers | ||
| reviewboard | |||
| None | Review Board SVN | ||
When you committed my most recent patch (http://reviews.review-board.org/r/352/) you made a slight change that introduced a bug. Specifically, ReviewRequest#publish no longer returns a ReviewRequest, which was expected in one place. Since there's no longer actually any reason to return a review request, I fixed it in the caller.
Try to submit a review request from the web UI. You'll see a 500 error without this patch.
Expand changes| trunk/reviewboard/reviews/views.py | |||
|---|---|---|---|
| Revision 1412 | New Change | ||
| ... | 369 lines hidden [Expand] | ||
| 370 | pass # FIXME show an error |
370 | pass # FIXME show an error |
| 371 | 371 | ||
| 372 | if not review_request.can_publish(): |
372 | if not review_request.can_publish(): |
| 373 | raise HttpResponseForbidden() |
373 | raise HttpResponseForbidden() |
| 374 | 374 | ||
| 375 | review_request = review_request.publish(request.user) |
375 | review_request.publish(request.user) |
| 376 | 376 | ||
| 377 | return HttpResponseRedirect(review_request.get_absolute_url()) |
377 | return HttpResponseRedirect(review_request.get_absolute_url()) |
| 378 | except PermissionError: |
378 | except PermissionError: |
| 379 | raise HttpResponseForbidden() # XXX Error out |
379 | raise HttpResponseForbidden() # XXX Error out |
| 380 | 380 | ||
| ... | 219 lines hidden [Expand] | ||
- trunk/reviewboard/reviews/views.py: 1 change [ 1 ]
Other reviews