Review Board

beta

Migrate to newforms-admin and django.forms

Submitted
Updated 4 months ago

Christian Hammond Reviewers
trunk reviewboard
None Review Board SVN
The Django newforms-admin and full newforms migrations happened in trunk recently, so we needed to update accordingly.

This change strips out all the inner Admin classes from the models and moves to the new Admin classes in admin.py files. We auto-discover early on (making sure we only do it once so that we don't break unit tests -- will need to ask Django to fix this in the future). We also move to importing django.forms instead of django.newforms.
Ran all unit tests and made sure the admin site was working as expected.
Ship it!
Posted 4 months ago (July 21st, 2008, 5:29 p.m.)

   

  
/trunk/reviewboard/accounts/admin.py (Diff revision 1)
11
print "Registering ReviewRequestVisit"
Left over debug output.
/trunk/reviewboard/accounts/models.py (Diff revision 1)
13
User._meta.admin.list_display += ('is_active',)
13
#User._meta.admin.list_display += ('is_active',)
14
User._meta.admin.list_filter += ('is_active',)
14
#User._meta.admin.list_filter += ('is_active',)
Can you just get rid of these?