Fix for post-review does not include new files w/ CVS
Updated 6 months ago
| Bob Miller | Reviewers | ||
| reviewboard | |||
| 533 | |||
| None | Review Board SVN | ||
Added the "-N" flag to the "cvs diff" command. I am not a submitter for review board. Can someone please check this in?
Tested by posting a review that includes three new files.
Diff revision 1 (Latest)
- /trunk/reviewboard/contrib/tools/post-review: 1 change [ 1 ]
Expand changes| /trunk/reviewboard/contrib/tools/post-review | |||
|---|---|---|---|
| Revision 1357 | New Change | ||
| ... | 517 lines hidden [Expand] | ||
| 518 | 518 | ||
| 519 | return self.do_diff(rev_str) |
519 | return self.do_diff(rev_str) |
| 520 | 520 | ||
| 521 | def do_diff(self, params): |
521 | def do_diff(self, params): |
| 522 | # Diff returns "1" if differences were found. |
522 | # Diff returns "1" if differences were found. |
| 523 | return execute('cvs diff -u %s' % params, |
523 | return execute('cvs diff -uN %s' % params, |
| 524 | extra_ignore_errors=(1,)) |
524 | extra_ignore_errors=(1,)) |
| 525 | 525 | ||
| 526 | 526 | ||
| 527 | class SVNClient(SCMClient): |
527 | class SVNClient(SCMClient): |
| 528 | """ |
528 | """ |
| ... | 965 lines hidden [Expand] | ||
- /trunk/reviewboard/contrib/tools/post-review: 1 change [ 1 ]
Other reviews