View DiffTLS support for LDAP authentication
Submitted
Updated 4 months, 2 weeks ago
| Dan Sheridan | Reviewers | ||
| reviewboard | |||
| None | Review Board SVN | ||
Add TLS support to the LDAP authentication backend. Enable by adding LDAP_TLS=True to settings_local.py. Assumes appropriate settings (certificate, etc.) in /etc/ldap/ldap.conf.
Authentication continues to work here.
If your server supports LDAP over SSL, you can just use "ldaps://..." in the LDAP_URI. That's probably a simpler route for most people. If the server doesn't listen on port 636, then you have to use a normal "ldap://" on port 389 and call start_tls_s(). Your change looks fine to me for that case.
Looks good. Committed as r1391.