Review Board

beta

Add the djblets.feedview app for viewing RSS/Atom feeds

Submitted
Updated 5 months, 1 week ago

Christian Hammond Reviewers
trunk reviewboard
None Navi 
This introduces the new djblets.feedview app, which is designed to allow sites to embed RSS/Atom feeds. We make use of the single-file MIT-licensed "feedparser" module for this, which we ship along with feedview.

This is to be used in the new admin UI for displaying Review Board news updates on the new dashboard.
Tested along with the new admin UI. Viewing feeds works fine.
David Trowbridge
Posted 5 months, 2 weeks ago (June 8th, 2008, 4:36 p.m.)

   

  
    
   
  




   



    

     
     

      
       
       
       
       
      
      
       

        
         /trunk/djblets/djblets/feedview/feedparser.py
		 

		  (Diff revision 1)

		 
        
       

      

      

       

         
         

         14
         
__version__ = "4.2-pre-" + "$Revision$"[11:14] + "-svn"

       


      

     

    

    

     
Huh.  This doesn't look right.

	 

  
    
   

   
  1. 
    
    
     
    
      
      Christian Hammond
      5 months, 1 week ago (June 9th, 2008, 4:09 p.m.)
      
     
    
     
    Yeah, but it shouldn't hurt us... I'd rather not modify feedparser code. It's easier if we can just drop in new versions down the road.
    
    
    
   
    2. 



   
  2. 
    
    
     
    
      
      David Trowbridge
      5 months, 1 week ago (June 9th, 2008, 4:15 p.m.)
      
     
    
     
    It looks like this is meant to be used via "svn cat" (or equivalent), so it fills in the revision number.  I'd really like to have that number here so we know which version of feedparser we've got.
    
    
    
   
    3. 



   
  3. 
    
    
     
    
      
      Christian Hammond
      5 months, 1 week ago (June 9th, 2008, 5:54 p.m.)
      
     
    
     
    Fixing this. It'll be in my commit.
    
    
    
   
    4. 


  



    


    

     
     

      
       
       
       
       
      
      
       

        
         /trunk/djblets/djblets/feedview/views.py
		 

		  (Diff revision 1)

		 
        
       

      

      

       

         
         

         35
         
        return cache_memoize("feed-%s" % url, fetch_feed, cache_expiration,

       


      

     

    

    

     
Do you need to escape url here?

	 

  
    
   

   
  1. 
    
    
     
    
      
      Christian Hammond
      5 months, 1 week ago (June 9th, 2008, 5:53 p.m.)
      
     
    
     
    Could have sworn I replied to this, but I guess not. I think that was while my wireless drivers messed up and had to be reset...

Anyhow, it worked during my tests. I thought about escaping it but I don't know that we're using any invalid characters in general. If anything, maybe cache_memoize should escape keys that come in.
    
    
    
   
    2.