View DiffAdd parent diff support to the JSON API and post-review
Submitted
Updated 5 months, 1 week ago
| Christian Hammond | Reviewers | ||
| trunk | reviewboard | ||
| None | Review Board SVN | ||
This adds support for uploading parent diffs in the JSON API, and also introduces a --parent flag to post-review for doing parent diffs on supporting repository types (currently only git-svn). It should be pretty easy to add the support to the other types.
Posted some standard diffs to make sure they didn't break. Then posted a diff with a parent diff. Saw that it uploaded as I expected.
Posted 5 months, 3 weeks ago (May 26th, 2008, 1:20 p.m.)
-
/trunk/reviewboard/contrib/tools/post-review (Diff revision 1) 453 def diff(self, args):
469 def diff(self, args):
454 return None
470 return (None, None)
-
I'd like you to add docstrings to all the diff/do_diff/etc functions that explain what this tuple is, because it's not immediately obvious except in the one case where it's actually implemented.
-
/trunk/reviewboard/contrib/tools/post-review (Diff revision 1) 1431 help="the parent branch this diff should be " +
-
You don't need the +; python will concatenate strings a lot like a C preprocessor.
Looks good!