Review Board

beta

Show a valid error when "Base Diff Path" is missing.

Updated 7 months, 3 weeks ago

David Trowbridge Reviewers
trunk reviewboard
460
None Review Board SVN 
Some users were trying to create review requests against subversion repositories
via the web form without specifying a base diff path.  This was showing this
error: 'UploadDiffForm' object has no attribute 'cleaned_data'

This sucks.  This change just catches the AttributeError and raises something
more meaningful.
Tried adding a diff without specifying the base diff path.
Ship it!
Christian Hammond
Posted 7 months, 3 weeks ago (May 18th, 2008, 1:07 a.m.)

   

  

   
    
    
   




   



    

     
     

      

       
       Loading diff fragment...
      

     

    

    

     
Could just use '' for the outside quotes and "" for the inside.

     

  

   
    
    

   
  1. 
    
    
     
    
      
      David Trowbridge
      7 months, 3 weeks ago (May 18th, 2008, 1:42 a.m.)
      
     
    
     
    Okay.
    
    
    
   
    2. 


   



    

    

    

     
     

      

       
       Loading diff fragment...
      

     

    

    

     
Why are we deleting this?

     

  

   
    
    

   
  1. 
    
    
     
    
      
      David Trowbridge
      7 months, 3 weeks ago (May 18th, 2008, 1:42 a.m.)
      
     
    
     
    Whoops!
    
    
    
   
    2.