Escape Subversion URLs

Submitter:	Dan Sheridan	Reviewers
Branch:		Groups:	reviewboard
Bugs:		People:
Change Number:	None	Repository:	Review Board SVN

Description:

This patch escapes the URL passed to Subversion so that paths with spaces in them work correctly. Without this, a cryptic "Malformed repository URL" message is shown to the user when submitting via the new review request form.

Testing Done:

Verified working with patches to files with spaces in the filenames and spaces in the paths, for both http:// and file:/// repository URLs.

Loading diff fragment...

Also, it seems like __normalize_path is a natural place for this to go, instead of here.

Dan Sheridan 8 months, 3 weeks ago (April 21st, 2008, 2:30 a.m.)

Well, yes and no. __normalize_path seems to be about figuring out whether the path is relative to the repo or already includes the repo. Escaping seems like a different task. I'm happy to do it either way though.

David Trowbridge 8 months, 3 weeks ago (April 21st, 2008, 3:07 p.m.)
```
OK, I guess that makes sense.  It's fine to leave this here.
```

Loading diff fragment...

Can you add a comment explaining why this is here?

Dan Sheridan 8 months, 3 weeks ago (April 21st, 2008, 2:30 a.m.)

Do you mean the urlsplit or the whole block of code? (the urlsplit is there to avoid escaping the : in http://)

David Trowbridge 8 months, 3 weeks ago (April 21st, 2008, 3:07 p.m.)
```
I mean the whole block.
```
Dan Sheridan 8 months, 3 weeks ago (April 22nd, 2008, 2:58 a.m.)
```
See updated patch
```

Committed as r1310.  Thanks!

Review Board

beta

This change has been marked as submitted.