Review Board

beta

Add basic Git support (against an SVN remote only) to post-review

Updated 9 months, 2 weeks ago

Christian Hammond Reviewers
trunk reviewboard
None Review Board SVN 
This change adds the beginning of Git support to post-review. Right now, it only generates diffs for repositories against SVN remotes and only generates a single squashed change rather than a patchset (as Review Board doesn't yet support this). However, it's a step. Additional features will likely require changes in Review Board, which may wait until 2.0. This does make my life easier now, though :)

We scan to see if this is a repository against an SVN remote and then generate a diff in the format that `svn diff` would generate.
I posted this review request!
David Trowbridge
Posted 9 months, 2 weeks ago (March 28th, 2008, 3:58 p.m.)

   

  

   
    
    
   




   



    

     
     

      

       
       Loading diff fragment...
      

     

    

    

     
What will happen if the code reaches here?  Should there be some sort of error or warning?

     

  

   
    
    

   
  1. 
    
    
     
    
      
      Christian Hammond
      9 months, 2 weeks ago (March 28th, 2008, 4:04 p.m.)
      
     
    
     
    It just won't return a valid repository and post-review will complain that it can't do anything with the tree you're in.
    
    
    
   
    2. 



   
  2. 
    
    
     
    
      
      David Trowbridge
      9 months, 2 weeks ago (March 29th, 2008, 12:38 a.m.)
      
     
    
     
    OK, Ship it!
    
    
    
   
    3.