Review Board

beta

Allow repositories to specify the default encoding

Updated 10 months, 3 weeks ago

David Trowbridge Reviewers
trunk reviewboard
380
None Review Board SVN
Until now, we've been assuming that all source files are either UTF-8
or ISO-8859-15.  This breaks things for people who use other, incompatible
encodings like Shift-JIS.

This change adds an optional encoding field to the repository model so
people can set it there.  This is probably the best we can do, since I
don't know of any VCS that actually keeps track of the encoding of files
stored inside it.

 
Posted 11 months ago (February 9th, 2008, 3:07 p.m.)

   

  
Loading diff fragment...
We hard-code this in several places. Maybe we should have a global setting for the default and reference that.
  1. David Trowbridge 10 months, 4 weeks ago (February 10th, 2008, 4:52 p.m.)
    It turns out this was just me being silly -- it only needs to be in one spot anyhow.
Ship it!
Posted 10 months, 3 weeks ago (February 13th, 2008, 1:30 a.m.)
Looks good.