Review Board

beta

Properly handle summaries in perforce changesets which span multiple lines

Updated 1 year, 7 months ago

David Trowbridge Reviewers
trunk reviewboard
None Review Board SVN
Phil has a changeset on reviewboard.eng with the following
format:
> Changes:
> blah blah blah
>
> Details:
> blah blah

Apparently perforce actually shows "Changes: blah blah blah" as
the summary line, so it makes sense to support this.  This change
will try to find '\n\n' within the first 100 characters of a
changeset description.  If it finds it, it'll take everything up
to that, replace newlines with spaces, and use that as the summary.
Added a sample changeset in testdata, a unit test, and ran
all tests.
Ship it!
Posted 1 year, 7 months ago (May 24th, 2007, 12:14 a.m.)
Looks fine. Just one question.
Loading diff fragment...
Can we instead just replace '\n' with ' '?
  1. David Trowbridge 1 year, 7 months ago (May 24th, 2007, 10:56 a.m.)
    Yup, done.