Review Board

beta

Process the install directory into sample config files

Updated 1 year ago

David Trowbridge Reviewers
trunk reviewboard
None Review Board SVN
We ship sample config files for lighttpd+fastcgi, apache+fastcgi and apache+mod_python.  One of the things that always bothered me about these is that they had the paths used by the various contributors of these configs.  Surprisingly, not everyone wants to install reviewboard into /root/reviewboard or /usr/share/reviewboard.

Since we've now got this great build system to install things with, we can make it so these configs have the right paths for everything, and just require people to fill in their host name and port.

There's more to do for this before everything is super sweet.
1. Verify that everything that needs to be installed is, actually, installed.
2. Make sure everything that we want to distribute is, actually, distributed.
3. Write init scripts for various linuxes (although maybe just sysvinit is OK, since I bet gentoo will write their own).
4. Build a virtual appliance.  Use this experience to make sure that there are a minimum of steps for a user.
5. Update the GettingStarted wiki page.
6. Write other docs, such as README, AUTHORS, etc.
7. 1.0
- Ran make install and checked resulting config files.
- Make distcheck
Posted 1 year ago (December 16th, 2007, 11:41 p.m.)
Sweet. This generally looks good.

While we're in these files, there's a few things we should clean up.
Loading diff fragment...
We might want to document this a little. Specifically talk about the port and timeout implications.
  1. David Trowbridge 1 year ago (December 22nd, 2007, 9:32 p.m.)
    Done.
Loading diff fragment...
Strip the trailing slash.
  1. David Trowbridge 1 year ago (December 22nd, 2007, 9:32 p.m.)
    Done.
Loading diff fragment...
Are these still needed with the aliases above? One or the other should be nuked.
  1. David Trowbridge 1 year ago (December 22nd, 2007, 9:33 p.m.)
    I think it was temporary while I was trying to get things working.  Removed.
Loading diff fragment...
Should probably nuke these.
  1. David Trowbridge 1 year ago (December 22nd, 2007, 9:33 p.m.)
    Removed.
Loading diff fragment...
This path is going to be wrong on anything not Python 2.4. Also, it doesn't match what we're doing in the other Apache file. What should /media be pointing to?
  1. David Trowbridge 1 year ago (December 22nd, 2007, 9:36 p.m.)
    I've added some code to detect where the django installation is and use the correct path.  If django isn't installed at the time they do make install, it'll say /path/to/django/...
Loading diff fragment...
Trailing / on errordocs.
  1. David Trowbridge 1 year ago (December 22nd, 2007, 9:36 p.m.)
    Fixed.
Loading diff fragment...
Do we have any /errordocs here anywhere?
  1. David Trowbridge 1 year ago (December 22nd, 2007, 9:36 p.m.)
    Added.
Loading diff fragment...
Same comment about /media here.
  1. David Trowbridge 1 year ago (December 22nd, 2007, 9:36 p.m.)
    Fixed.
Ship it!
Posted 1 year ago (December 22nd, 2007, 11:39 p.m.)
Looks great. Ship it!