Review Board

beta

Cache the full diff files list rather than only chunks

Updated 1 year, 4 months ago

Christian Hammond Reviewers
trunk reviewboard
None Review Board SVN
We were caching the chunks that made up the get_diff_files list, when the only time the chunks were useful were in get_diff_files. So let's cache the results of that instead. Same with the file coming from the SCM backend, in order to make more room for the get_diff_files cache. In theory, if this falls out of the cache, we'll probably have lost the file contents anyway. Besides, we weren't caching HEAD files anyway.
Caching seems to work in the diff viewer and review request page with comments.
Ship it!
Posted 1 year, 4 months ago (August 18th, 2007, 9:10 p.m.)
Looks OK.  I see this is already in SVN.
Loading diff fragment...
Hrm.  This is kind of confusing, being so far down from the actual function definition.  I wonder if it might make sense to move those internal functions out now...
Posted 5 months, 2 weeks ago (July 24th, 2008, 2:26 a.m.)