Review Board

beta

Cache diff file fragments

Updated 1 year, 6 months ago

David Trowbridge Reviewers
trunk reviewboard
None Review Board SVN 
We were spending a lot of time in each view_diff rebuilding the diffs.  Except for variations due to collapsing and syntax hilighting, these won't actually change.  Rendering these to strings and caching the results has resulted in my profile being mostly inside view_diff to being mostly inside django internals and locmem caching code.  Whoopee.
Looked at both collapsed and expanded versions of the diff.  Reloaded a bunch and looked at the profile data.
Christian Hammond
Posted 1 year, 6 months ago (June 29th, 2007, 2:13 a.m.)
Awesome. A few changes though.
Loading diff fragment... 
This can be simplified to:

return render_to_string(template_name, RequestContext(request, context))

You should then remove the import above to and add:

from django.template.loader import render_to_string
Loading diff fragment... 
Should be "highlighting"
Loading diff fragment... 
No need for parens arond the file['filediff'].id.
Loading diff fragment... 
"highlighting"